Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a measurement-only harness for PRD-564, where resolution changes may recreate render targets and pipelines. It reuses the authored starter bootstrap, checks actual runtime/adapter identity, records first-frame and following-window census data, and computes a fail-closed gate. Runtime optimization is not implemented.
Validation: 53 nearest probe/startup-ready tests and playtest TypeScript previously passed; current whole-repository lint passes. Normal pre-push agents/docs/lint/drift checks passed; these do not prove runtime behavior. A prior hardware preflight passed functional checks only on named NVIDIA Turing at pinned scale 1. The current full measurement reached its 240-second deadline with 0/3 contexts and 0/9 steps completed, no gate verdict, and unqualified host timing. Descriptor byte sums are not physical memory measurements.
The separate lint repair preserves the donor's fixed public/math-schema property names through an exact-file naming override. Isolated containment checks passed, while nonallowlisted names and other paths remain checked. Donor source is unchanged.
Progress remains 0%. No optimization, native parity, cost improvement or visual verdict is claimed. Visual comparisons/judging remain open; draft/skipped CI is not a passing runtime qualification.
TL;DR —
ResolutionScaler(packages/core/src/resolution-scaler.ts) picks one of 10 rungs, from 1.0 to 0.23. Its own comments say why the rungs are coarse: "every step reallocates render targets on WebGPU, and fine granularity buys smoothness with hitches" (:20-24), and "the resize reallocates every render target, which rebuilds pipelines" (:72-73).0% by the PRD's own boxes: 0/3 phases (0/5 boxes), 0/2 acceptance criteria. PRD:
docs/PRDs/unreal-source-borrowing/PRD-564-the-resolution-scale-changes-without-reallocating-a-target.md.Phases
Phase 1: Price the resize — 0/1
node packages/playtest/dist/runner/cli.js perfon the scenario, results under## Decisionswith the continue or decline call.Phase 2: Draw into the sub-rectangle — 0/2
pnpm exec vitest run packages/core/__tests__/renderer*.spec.tswith an allocation-counting renderer stub.refusedand keeps the reallocation path. proof: red-green chain spec, one case per stage inRENDER_CHAIN_STAGE_ORDER.Phase 3: Finer steps and native — 0/2
pnpm exec vitest run packages/core/__tests__/resolution-scaler*.spec.ts.pnpm parity --target desktop --only-tests resolution-subrect.Acceptance criteria
node packages/playtest/dist/runner/cli.js perfwith a forced-step scenario,TN_FRAME_BUDGETand the pipeline census. — Evidence: pending.pnpm visuals:ab. — Evidence: pending.Still open
node packages/playtest/dist/runner/cli.js perfon the scenario, results under## Decisionswith the continue or decline call.pnpm exec vitest run packages/core/__tests__/renderer*.spec.tswith an allocation-counting renderer stub.refusedand keeps the reallocation path. proof: red-green chain spec, one case per stage inRENDER_CHAIN_STAGE_ORDER.pnpm exec vitest run packages/core/__tests__/resolution-scaler*.spec.ts.pnpm parity --target desktop --only-tests resolution-subrect.node packages/playtest/dist/runner/cli.js perfwith a forced-step scenario,TN_FRAME_BUDGETand the pipeline census. — Evidence: pending.pnpm visuals:ab. — Evidence: pending.Generated from the PRD's checkboxes. Regenerate on each push so the PR and the PRD never disagree.