Skip to content

Show concrete field changes so an unfamiliar reviewer can act on the first advisory result #795

Description

@pengfei-threemoonslab

Problem

A reviewer should be able to identify what changed, inspect its evidence and decide the next action without a maintainer translating Agents Shipgate output. A row such as PostToolUse → PostToolUse, widened, high does not explain a matcher, command or timeout change.

The September 15 1.0.0 exploratory report (F6) observed that shape on Giskard#2618. The earlier MemWal#913 example displayed memwal → memwal while a package argument was pinned. These dated examples motivate a fixed-ref replay; they do not establish that every current path still behaves identically. Information loss and an unsupported direction classification must be diagnosed separately.

Proposed behavior

Start with #780/#786's advisory PR result and its linked report, reusing the shared capability rows and renderer. Make the changed subject and actual before/after values visible first. Keep the canonical project identity discoverable once.

For supported hook and MCP rows, expose the relevant field changes:

  • Hooks: event, matcher, command summary and timeout where the reader establishes them.
  • MCP launch configuration: the established command/argument change, including a version pin when safely displayable.
  • Permission rules: actual added/removed/changed rules and their declaration source.

Use bounded detail with existing redaction. A detected declaration change does not itself prove widening, narrowing or effective runtime authority. Where direction is not established, publish the observed change and its limit through the compatible engine-owned contract; do not have a renderer invent a verdict.

Keep the evidence and a specific review question together. “Do we intend this declared permission change?” can be useful even when another reviewer already knows about it. Novelty is not an eligibility requirement for #811's value test.

Boundaries

  • Removing a tracked hook declaration establishes removal from that declaration. Mention migration to local/generated configuration only when supported reference/generation evidence establishes it; otherwise name the unavailable scope.
  • Pairing old/new entries for readability must not assume case-insensitive command semantics. Preserve meaningful case changes and distinct rules.
  • Show what each host comparison checked, partially checked and could not establish #812 owns per-run coverage data; this renderer consumes it rather than inventing a parallel census.
  • Reproduction belongs in the linked report with exercised refs/history/version. No compulsory reinstall, manifest, baseline or policy authoring.
  • Explicit requests still return accurate no-change/incomplete status. Preserve quiet, deduplicated unsolicited notifications; do not append marketing or mandatory questions everywhere.
  • Preserve all existing control/authority semantics and the Revisit the legacy repository skill after readiness: prove its value before restoring default invocation #690 disposition.

Acceptance

Sequence

P1, first product improvement in #811. Reuse #798's example work and #662's parity infrastructure. Coverage detail follows through #812; do not wait for expanded framework support or every reliability repair before observing a supported first result.

Parent #791; product-validation link #811. Related #652, #362, #463, #661, #779, #780, #440, #328, #653, #571.

Journey delivery - 2026-09-16

Program: #778. Delivery milestone: Adoption Phase 1 - A real change the reviewer understands. Accountable role: CLI/report engineering with product/research.

This is the first selected product improvement. Its consumer is a non-author reviewer who must name the actual field change, evidence, unresolved scope and a concrete next action without maintainer translation. Reuse the same row facts in CLI, maintained JSON and the selected #780 PR presentation. #812 supplies coverage; #811 uses these outputs for decisions and correction. Validate fixed-ref hook/MCP examples plus the chosen shell case; observe external comprehension through #653/#571. Do not call an observed configuration change widening unless the engine establishes that direction.

Planning checkpoints preserve #778's original 2026-09-14 start: Oct 14 / Nov 13 / Dec 13. They are evidence-review dates, not promises about external replies. Phases overlap; a later milestone never delays supported research, an already-possible correction or an individual four-week opportunity window. A named accountable owner is required before execution; the role here is not an assignment to an uninvolved person.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Next after P0; blocks other work or ships a misleading resultarea:agent-modeAgent-mode contract: control envelope, next actions, command stringsenhancementNew feature or requestworkstream:hostHost-configuration comparison correctness, coverage and performance.

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions