Repository navigation
Conversation
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
FayeSpica
requested review from
hsliuustc0106 and
princepride
as code owners
November 15, 2026 13:58
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
Signed-off-by: Weiming Liao <liaowm5@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render a saved timeline without opening its editor: use Output video in the node toolbar or ⌘Enter / Ctrl+Enter. A pending video node shows progress, cancellation and retry; successful publication fills the same node with the playable MP4.
timeline.publishRender, with source/output revision and lock checks. Retry an unknown publication using the same operation ID and rendered asset.Linked issue / Related PR
Related to #331, which exposes shared publication commands to Agent tools and accepts
agent_writtenartifacts. This change adds the canvas entry, pending presentation and output versions. It currently targets main without #331; integration must preserve #331's routing and artifact validation. Agent-tool publication has not been verified here.No closing issue.
Labels
Applied:
type:feat,area:canvas,area:timeline,modality:video.Test plan
At
3a1df61d,npm testpassed all 818 tests, including fresh render import and retry snapshot coverage.At
a7255d29, the completetimeline_node_output.mjsworkflow passed three consecutive runs with CI-pinned Playwright 1.58.2 and Chromium headless shell. It also covers source removal and publishing identical rendered bytes as distinct versions. Build, i18n, browser locale and browser manifest checks passed. CI passed at3a1df61d: Release checks.Validated on
fcac231aplus the local changes:python -m pytest tests/test_creation_timeline_render.py tests/test_creation_contracts.py -q: 106 passed, covering repeated publication, version restoration, locks, stale revisions and contract round trips.npm test: 818 passed before the final removal of the redundant output panel; the final UI passed the browser workflow below.node tests/browser/timeline_node_output.mjs: passed against the isolated API and Vite, including real MP4 rendering, toolbar output, both shortcut modifiers, cancellation, publication retry, provenance edges, three versions in one node, restoration and project reopening.npm run build,npm run check:i18n, browser manifest and locale checks passed.3a1df61d.Evidence that it works
The browser workflow verifies that the pending node ID becomes the published video node ID and repeated renders retain one node with three selectable versions. A rendered sample passed full FFmpeg decoding (160×96, 24 FPS, 12 frames).
Captured from port 18000 using a separate project and real local rendering (6 seconds, 832×480, 24 FPS):
Provider verification
No model-provider calls. Video rendering uses the actual browser encoder and local files; Agent-tool delivery through #331 remains unverified.
Bilingual UI
zh-CNanden-USstrings and user guides updated; both languages exercised in the browser workflow.