Repository navigation
Conversation
5 tasks done
MrDongsls
force-pushed
the
feat/stage-node-entry
branch
2 times, most recently
from
November 15, 2026 03:26
4c94079 to
25b41bc
Compare
- Enable the Director Stage entry in the shared creation toolbar and open the stage editor automatically after creating the node. - Pin node, document, and keyframe identity across editor.save, undo, redo, and storage reload with a service-level command test. - Add a browser acceptance flow covering creation, editing, undo, redo, and reopen, runnable in en-US and zh-CN via DIRECTOR_STAGE_LOCALE. - npm test (676 passing at this commit's tree state). - .venv/bin/python -m pytest tests/test_creation_director.py. - node tests/browser/director_stage_entry.mjs plus the DIRECTOR_STAGE_LOCALE=zh-CN run, against the isolated creation_server.py fixture. Refs: ThinkFlowLab#241
MrDongsls
force-pushed
the
feat/stage-node-entry
branch
from
November 15, 2026 03:36
25b41bc to
8528e1c
Compare
MrDongsls
marked this pull request as ready for review
November 15, 2026 05:08
MrDongsls
requested review from
hsliuustc0106 and
princepride
as code owners
November 15, 2026 05:08
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
area:canvas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #241
Summary
The creation menu and tool rail can create a Director Stage node, the editor opens right after creation, and the stage document persists through apply, close, and reopen. This is slice 1 of 4 delivering #241; the import pipeline, output assets, and agent publishing land on top in #329, #330 and #331.
src/canvas/creationTools.tsregisters theexternalDirector Stage entry;src/canvas/workspace/useWorkspaceInteraction.tsxopens the editing session for the new node.externalnode's editor binding projects to adirectoreditor document, covered by backend contract tests intests/test_creation_director.py.tests/browser/director_stage_entry.mjscovers create, edit, apply, reopen, undo and redo in bothen-USandzh-CN.Linked issue
Labels
type:feat,area:canvasTest plan
npx tsc --noEmitclean;npm test676/676;npm run check:i18n0 problems;.venv/bin/python -m pytest tests/test_creation_director.py1 passed;node tests/browser/director_stage_entry.mjsandDIRECTOR_STAGE_LOCALE=zh-CN node tests/browser/director_stage_entry.mjsboth pass (checks: shared creation toolbar entry, automatic editor opening, external node projects to director document, keyframes persist and reopen, undo and redo preserve identities, no page errors).Evidence that it works
tests/browser/creation_server.pybackend:Provider verification
Bilingual UI