feat(destination): optional scope param on getLiveData/buildLiveData#232
Merged
Conversation
Adds an optional `scope?: ReadonlySet<string>` to getLiveData() (final) and buildLiveData(), threaded through unchanged. Lets a streaming (push) destination build live data for only the entities whose source docs changed this fire (emit-per-changed-entity) instead of a full-park snapshot. Undefined scope — the default, and every poll/REST destination — builds everything exactly as before; ~50 existing buildLiveData() overrides ignore the new trailing optional param and stay full-snapshot, so no subclass changes are needed. The param carries only public entity ids (no secrets). Contract test added: getLiveData threads its scope through to buildLiveData (and undefined when omitted). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KPNw8f4pE63C9hE2Xy4ykt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
scope?: ReadonlySet<string>togetLiveData()(final) andbuildLiveData(), threaded straight through.Streaming (push) destinations can pass the published entity ids whose source docs changed this fire, so the build is emit-per-changed-entity instead of a full snapshot. Undefined scope — the default, and every poll/REST destination — builds everything exactly as before; ~50 existing
buildLiveData()overrides ignore the new trailing optional param and stay full-snapshot, so no subclass changes.The collector uses this to restore the legacy .NET push model for Disney and end a park-close data freeze (collector PR linked separately).
getLiveDatathreads its scope through tobuildLiveData(and passesundefinedwhen omitted).🤖 Generated with Claude Code