Conversation
zapsentry.Tag and zapsentry.Context were only honoured when passed directly to the log call. Fields attached earlier via zap's Logger.With were silently dropped, because core.with() did not carry them into the child core and Write() only scanned the call-site fields. Store tags and the context on the core in with(), and have Write() read them from the already-computed clone. Add regression tests for both fields.
Contributor
Author
|
FYI, the benchmarks look slightly better in some cases. The ones that look worse are actually the feature working as it should 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zapsentry.Tagandzapsentry.Contextwere only honored when passed directly to the log call. Fields attached earlier via zap'sLogger.Withwere silently dropped, becausecore.with()did not carry them into the child core andWrite()only scanned the call-site fields.Store tags and the context on the core in
with(), and haveWrite()read them from the already-computed clone. Also added regression tests for both fields.Fixes #56