Prompt V2 - #138
Merged
Merged
Prompt V2#138
Conversation
Neffi42
commented
Oct 15, 2025
Neffi42
commented
Contributor
- add tty id
- update tty_print_pompt
- add tty.input_start to correct BOF in try_build_command
Contributor
There was a problem hiding this comment.
Pull Request Overview
Introduce a colored, per-TTY prompt that includes the TTY id, and track the start of user input to prevent backspacing over the prompt and to avoid submitting empty commands.
- Add id and input_start fields to tty_t and initialize them.
- Replace static prompt string with a formatted, colored prompt; update backspace logic and command building to use input_start.
- Introduce try_build_command returning bool; only dispatch commands when non-empty.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| kernel/src/tty/tty.c | Implements colored prompt with TTY id, tracks input_start, adds try_build_command, updates backspace and Enter handling. |
| kernel/include/tty.h | Extends tty_t with id and input_start fields. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
iamantoinev
reviewed
Oct 15, 2025
Neffi42
force-pushed
the
65-first-line-with-basic-informations
branch
from
October 15, 2025 11:13
37fd7ad to
c93116b
Compare
|
Neffi42
enabled auto-merge (squash)
October 15, 2025 11:14
iamantoinev
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.