fix(web): override browserslist past the prototype-write advisories - #507
Merged
Conversation
`pnpm audit` began failing against a lockfile nobody had touched: two high advisories landed against browserslist <=4.28.6 — GHSA-c83g-rgw3-j3cx and GHSA-73wf-gq98-2v4g, a prototype write and an uncaught crash reachable via an untrusted `browserslist-stats.json`. `dev` was green on its last run and is red on its next one for the same reason, so this is time, not a change. browserslist is reached only transitively (`vite-plugin-solid` -> `@babel/core` -> `@babel/helper-compilation-targets`), so no direct dependency can be bumped to reach it. An override is the mechanism, and this file already holds two of them for the same reason. 4.28.2 -> 4.28.8. `pnpm audit` reports no known vulnerabilities, the PWA builds (132 assets) and the suite passes 858/858.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm auditbegan failing against a lockfile nobody had touched. Two high advisories landed againstbrowserslist <=4.28.6:Both are a prototype write / uncaught crash reachable via an untrusted
browserslist-stats.json.dev's last CI run (2026-09-01 10:28) was green and its next one is red for the same reason, so this is time passing, not a change landing.browserslist is reached only transitively —
vite-plugin-solid→@babel/core→@babel/helper-compilation-targets→browserslist— so no direct dependency can be bumped to reach it. An override is the mechanism, andweb/pnpm-workspace.yamlalready holds two for exactly this reason.Note the override goes in
pnpm-workspace.yaml, notpackage.json: pnpm 11 no longer reads apnpm.overridesfield there and ignores it with a warning.4.28.2 → 4.28.8.
Verification
pnpm audit— no known vulnerabilities (was: 2 high)pnpm build— 132 PWA assets, exit 0pnpm test— 100 files, 858 tests, all passingUnblocks #506, which is red only on this audit step.
🤖 Generated with Claude Code
https://claude.ai/code/session_01RzFCTnWGff1k4FyX1HQCYM