Skip to content

perf: optimize lower with list comprehension #15230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclauss merged 1 commit into from
Sep 8, 2026
Merged

perf: optimize lower with list comprehension #15230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions strings/lower.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,16 @@ def lower(word: str) -> str:
>>> lower("whAT")
'what'
"""
result = []

for char in word:
code = ord(char)
if ASCII_UPPERCASE_START <= code <= ASCII_UPPERCASE_END:
char = chr(code + ASCII_CASE_OFFSET)
result.append(char)

return "".join(result)
start = ASCII_UPPERCASE_START
end = ASCII_UPPERCASE_END
offset = ASCII_CASE_OFFSET

return "".join(
[
chr(code + offset) if start <= (code := ord(char)) <= end else char
for char in word
]
)


if __name__ == "__main__":
Expand Down
Loading