fix: preserve KDTree deletion traversal and split invariants

src/main/java/com/thealgorithms/datastructures/trees/KDTree.java

@@ -406,12 +406,14 @@ private Node delete(Node root, Node node) {
             } else if (root.left != null) {
                 Node min = findMin(root.left, root.getAxis());
                 root.point = min.point;
-                root.left = delete(root.left, min);
+                root.right = delete(root.left, min);
+                root.left = null;
             } else {
                 return null;
             }
+            return root;
         }
-        if (root.getAxisCoordinate() < node.point.getCoordinate(root.getAxis())) {
+        if (node.point.getCoordinate(root.getAxis()) < root.getAxisCoordinate()) {
             root.left = delete(root.left, node);
         } else {
             root.right = delete(root.right, node);

src/test/java/com/thealgorithms/datastructures/trees/KDTreeDeletionTest.java

@@ -0,0 +1,165 @@
+package com.thealgorithms.datastructures.trees;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Set;
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+
+class KDTreeDeletionTest {
+    @Test
+    void deleteLeavesOnBothSides() {
+        for (int coordinate : new int[] {10, 30}) {
+            List<KDTree.Point> points = pointsOf(20, 10, 30);
+            KDTree tree = insertedTree(points);
+            KDTree.Point deleted = pointOf(coordinate);
+            tree.delete(deleted);
+            points.remove(deleted);
+            assertContents(tree, points);
+            Assertions.assertFalse(tree.search(deleted).isPresent());
+        }
+    }
+
+    @Test
+    void deleteNonRootWithDescendants() {
+        for (int coordinate : new int[] {10, 30}) {
+            List<KDTree.Point> points = pointsOf(20, 10, 30, 5, 15, 25, 35, 13, 27);
+            KDTree tree = insertedTree(points);
+            KDTree.Point deleted = pointOf(coordinate);
+            tree.delete(deleted);
+            points.remove(deleted);
+            assertContents(tree, points);
+            Assertions.assertFalse(tree.search(deleted).isPresent());
+        }
+    }
+
+    @Test
+    void deleteRootWithOnlyLeftSubtree() {
+        List<KDTree.Point> points = pointsOf(20, 10, 15, 5);
+        KDTree tree = insertedTree(points);
+        KDTree.Point deleted = points.removeFirst();
+        tree.delete(deleted);
+        assertContents(tree, points);
+        Assertions.assertFalse(tree.search(deleted).isPresent());
+        KDTree.Point inserted = pointOf(12);
+        tree.insert(inserted);
+        points.add(inserted);
+        assertContents(tree, points);
+        tree.delete(inserted);
+        points.remove(inserted);
+        assertContents(tree, points);
+    }
+
+    @Test
+    void deleteRootWithNestedRightSuccessor() {
+        List<KDTree.Point> points = pointsOf(20, 30, 25, 27, 40);
+        KDTree tree = insertedTree(points);
+        KDTree.Point deleted = points.removeFirst();
+        tree.delete(deleted);
+        assertContents(tree, points);
+        Assertions.assertFalse(tree.search(deleted).isPresent());
+        KDTree.Point successor = pointOf(25);
+        Assertions.assertEquals(successor, tree.getRoot().getPoint());
+        tree.delete(successor);
+        points.remove(successor);
+        assertContents(tree, points);
+        Assertions.assertFalse(tree.search(successor).isPresent());
+    }
+
+    @Test
+    void deletingAbsentPointPreservesContents() {
+        List<KDTree.Point> points = pointsOf(20, 10, 30);
+        KDTree tree = insertedTree(points);
+        Assertions.assertThrows(IllegalArgumentException.class, () -> tree.delete(pointOf(15)));
+        assertContents(tree, points);
+        for (KDTree.Point point : List.copyOf(points)) {
+            tree.delete(point);
+            points.remove(point);
+            assertContents(tree, points);
+        }
+        Assertions.assertNull(tree.getRoot());
+        Assertions.assertThrows(IllegalArgumentException.class, () -> tree.delete(pointOf(20)));
+        Assertions.assertNull(tree.getRoot());
+    }
+
+    @Test
+    void deletionOrdersPreserveBuiltAndInsertedTrees() {
+        for (int dimension : new int[] {1, 2, 3}) {
+            List<KDTree.Point> initial = new ArrayList<>();
+            for (int index = 0; index < 15; index++) {
+                int[] coordinates = new int[dimension];
+                for (int axis = 0; axis < dimension; axis++) {
+                    coordinates[axis] = index * (axis + 1) % 17 - 8;
+                }
+                initial.add(new KDTree.Point(coordinates));
+            }
+            for (boolean bulkBuild : new boolean[] {false, true}) {
+                for (int shift : new int[] {0, 4, 9}) {
+                    List<KDTree.Point> remaining = new ArrayList<>(initial);
+                    List<KDTree.Point> order = new ArrayList<>(initial);
+                    Collections.rotate(order, shift);
+                    KDTree tree = bulkBuild ? new KDTree(initial.toArray(KDTree.Point[] ::new)) : insertedTree(initial);
+                    assertContents(tree, remaining);
+                    for (KDTree.Point point : order) {
+                        tree.delete(point);
+                        remaining.remove(point);
+                        assertContents(tree, remaining);
+                        Assertions.assertFalse(tree.search(point).isPresent());
+                    }
+                    Assertions.assertNull(tree.getRoot());
+                }
+            }
+        }
+    }
+
+    private static KDTree.Point pointOf(int coordinate) {
+        return new KDTree.Point(new int[] {coordinate, coordinate});
+    }
+
+    private static List<KDTree.Point> pointsOf(int... coordinates) {
+        List<KDTree.Point> points = new ArrayList<>();
+        for (int coordinate : coordinates) {
+            points.add(pointOf(coordinate));
+        }
+        return points;
+    }
+
+    private static KDTree insertedTree(List<KDTree.Point> points) {
+        KDTree tree = new KDTree(points.getFirst().getDimension());
+        for (KDTree.Point point : points) {
+            tree.insert(point);
+        }
+        return tree;
+    }
+
+    private static void assertContents(KDTree tree, List<KDTree.Point> expected) {
+        List<KDTree.Point> actual = new ArrayList<>();
+        collectPoints(tree.getRoot(), actual);
+        Assertions.assertEquals(expected.size(), actual.size());
+        Assertions.assertEquals(Set.copyOf(expected), Set.copyOf(actual));
+        for (KDTree.Point point : expected) {
+            Assertions.assertTrue(tree.search(point).isPresent(), () -> "Surviving point is unreachable: " + point);
+        }
+        if (!expected.isEmpty()) {
+            for (int axis = 0; axis < expected.getFirst().getDimension(); axis++) {
+                int minimum = Integer.MAX_VALUE;
+                int maximum = Integer.MIN_VALUE;
+                for (KDTree.Point point : expected) {
+                    minimum = Math.min(minimum, point.getCoordinate(axis));
+                    maximum = Math.max(maximum, point.getCoordinate(axis));
+                }
+                Assertions.assertEquals(minimum, tree.findMin(axis).getCoordinate(axis));
+                Assertions.assertEquals(maximum, tree.findMax(axis).getCoordinate(axis));
+            }
+        }
+    }
+
+    private static void collectPoints(KDTree.Node node, List<KDTree.Point> points) {
+        if (node != null) {
+            points.add(node.getPoint());
+            collectPoints(node.getLeft(), points);
+            collectPoints(node.getRight(), points);
+        }
+    }
+}