Skip to content

C++: Support detecting IFC4X3_ADD2 schema#2006

Closed
thbeu wants to merge 1 commit into
ThatOpen:mainfrom
thbeu:fix-detect-schema
Closed

C++: Support detecting IFC4X3_ADD2 schema#2006
thbeu wants to merge 1 commit into
ThatOpen:mainfrom
thbeu:fix-detect-schema

Conversation

@thbeu

@thbeu thbeu commented May 20, 2026

Copy link
Copy Markdown
Contributor

Detect IFC4X3_ADD2 as IFC4x3, not IFC2x3.

@beachtom

Copy link
Copy Markdown
Collaborator

Thanks - but what issue is this solving? I think IFC4X3_ADD2 is already encoded in our schema map - so this shouldn't be needed. I think we are fixing a symptom here and not the route issue. Can you share an IFC file that is failing and I will check it.

@thbeu

thbeu commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

Any IFC with schema IFC4X3_ADD2 is detected as IFC2X3. This PR fixes the issue.

@beachtom

Copy link
Copy Markdown
Collaborator

I've just tested on main with an IFC4X3_ADD2 schema file and it detected it as IFC4X3_ADD2 can you share the files that are going wrong?

@thbeu

thbeu commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

For example: blue_cube.zip

Sorry, forgot to mention that I am on latest release being v0.0.77.

@thbeu

thbeu commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

Alternatively, you could fix schema-functions.cpp and ifc-schema.h to support the same set of schemas as in TS code. This PR seems to be rather a workaround.

@beachtom

Copy link
Copy Markdown
Collaborator

Okay - I get you - it is the C++ schema detection that is failing - leave it with me for a bit

@thbeu thbeu changed the title Support detecting IFC4X3_ADD2 schema C++: Support detecting IFC4X3_ADD2 schema May 28, 2026
@beachtom

beachtom commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

I have prepared: #2020 which should fix this

@beachtom beachtom closed this Jun 2, 2026
@thbeu thbeu deleted the fix-detect-schema branch June 3, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants