Conversation
ABujalance
reviewed
Mar 5, 2026
Comment on lines
+51
to
+52
| ' let groupsDone = 0;', | ||
| ' const totalGroups = 12;', |
Contributor
There was a problem hiding this comment.
Nitpick:
This is hardcoded — progress bar will silently break if you add or remove test groups. Consider deriving it from the actual number of report() calls so we don't need to worry about possible changes in the future
| // Clean up previous test suite if it exists | ||
| if (existsSync(parentDir)) { | ||
| console.log(`Removing existing directory "${directory}"...`); | ||
| rmSync(parentDir, { recursive: true, force: true }); |
Contributor
There was a problem hiding this comment.
Suggestion: I believe if someone calls thatopen create-tests without any arguments in their repo root this would nuke the repository. Deleting the subdirectories only could be safer in this case or we could force the argument to make it a bit safer.
ABujalance
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testandcloud-testtemplates that scaffold a browser test app and a cloud component test suite, respectively. Both exercise everyEngineServicesClientAPI endpoint (Files, Folders, Components, Apps, Execution, Hidden Files, Icons, Permissions, Built-in Components).testtemplate generates a full BIM app with a 3D viewport, model loading pipeline (GitHub → Storage → Scene), and a side panel displaying test results with pass/fail/skip icons, colors, and durations — grouped by API area.thatopen create-tests [directory](scaffolds both test projects, deletes the target directory first for a clean slate) andthatopen serve-tests [directory](runs both the test app dev server and the component's local execution server in parallel with prefixed output).test:cli-build-testsandtest:cli-serve-teststopackage.jsonfor one-command test suite scaffolding and serving.ENOENTerrors on Windows/Git Bash by replacingexecSync/shell-basedspawnwithspawnSync(process.execPath, ...)and removingshell: true.README.mdandCONTEXT.mdwith the new templates, CLI commands, npm scripts, and a full "Running the platform API test suite" guide.