feat: add icon support for items#6
Merged
Merged
Conversation
- Add uploadItemIcon, getItemIcon, removeItemIcon to EngineServicesClient - Add --icon flag to thatopen publish (persisted in .thatopen config) - Validates format (PNG/WebP/ICO) and size (512 KB max) before upload Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Augment Window interface for __THATOPEN_CONTEXT__ and ThatOpenCompany - Add ComponentsLike interface for OBC.Components duck-typing - Use typed inline casts for OBC/BUI globals in initApp - Zero `as any` remaining in src/ Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Rename eslint.config.js → .mjs, migrate .eslintignore to config ignores - Set @typescript-eslint/no-explicit-any to error - Add `eslint src/` as first step in build script - Fix ObjectId type (was `string | any`, now `string`) - Remove stale eslint-disable comment Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uploadItemIcon,getItemIcon,removeItemIconmethods toEngineServicesClient— wraps the newPUT/GET/DELETE /api/item/:id/iconbackend endpoints--icon <path>option tothatopen publish— uploads an icon (PNG, WebP, or ICO, max 512 KB) after publishing an app or component.thatopenconfig so subsequent publishes reuse it automaticallyChanges
src/core/client.tssrc/cli/commands/publish.ts--iconflag, validation, upload after publish, config persistencesrc/cli/lib/config.tsiconPathfield onThatOpenLocalConfigTest plan
yarn buildpassesthatopen publish --icon ./icon.pnguploads icon after publishthatopen publish(without--icon) reuses saved icon path🤖 Generated with Claude Code