Skip to content

Issue #2132: Fix timeout type cast exception when creating a deposit location.#2133

Open
jameswsullivan wants to merge 1 commit intoTexasDigitalLibrary:mainfrom
jameswsullivan:fix-deposit-loc-timeout-err
Open

Issue #2132: Fix timeout type cast exception when creating a deposit location.#2133
jameswsullivan wants to merge 1 commit intoTexasDigitalLibrary:mainfrom
jameswsullivan:fix-deposit-loc-timeout-err

Conversation

@jameswsullivan
Copy link
Copy Markdown
Contributor

Resolves issue: #2132

I've tested with our instances and it worked.

  • create with default timeout 240;
  • create with a different timeout, e.g. 1000;
  • create with default timeout 240, and then edit it to 1000.

@jameswsullivan jameswsullivan changed the title Use valueOf instead of type cast. Issue 2132: Fix timeout type cast exception when creating a deposit location. Mar 24, 2026
@jameswsullivan jameswsullivan changed the title Issue 2132: Fix timeout type cast exception when creating a deposit location. Issue #2132: Fix timeout type cast exception when creating a deposit location. Mar 25, 2026
@cstarcher cstarcher requested a review from Copilot May 7, 2026 18:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the deposit location creation failure caused by casting the timeout request field to Integer when it may arrive as a String (as reported in Issue #2132).

Changes:

  • Parse timeout from the incoming Map<String, Object> via string conversion and Integer.valueOf(...), preventing ClassCastException when the value is provided as a string.
  • Use a numeric default (240) for timeout when it is absent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants