Skip to content

Festac did - #447

Closed
festac-dev wants to merge 1 commit into
TestSprite:mainfrom
festac-dev:clean-pr
Closed

festac-dev wants to merge 1 commit into
TestSprite:mainfrom
festac-dev:clean-pr

Conversation

@festac-dev

@festac-dev festac-dev commented Oct 16, 2026 •

Copy link
Copy Markdown

Summary by CodeRabbit

  • Tests
    • Improved test reliability across platforms by accounting for filesystems that do not enforce permission settings and validating Windows-style path handling.
    • Added more time for slower subprocess tests to complete, reducing avoidable test failures.
    • Updated test execution to handle Linux permission capabilities where applicable.

@github-actions

Copy link
Copy Markdown

Thanks for the PR, @festac-dev! A quick note on our workflow: for features and behavior changes we require contributors to open an issue first, claim it by commenting /assign on the issue, then submit a PR that references it (e.g. Closes #123, or Part of #123 when the issue is an umbrella that shouldn't be closed by one PR). This PR isn't linked to any issue yet, so it is not review-ready. After fixing it, edit the PR description or push a commit to re-run this check. See CONTRIBUTING → Contribution model.

@github-actions github-actions Bot added the needs-issue PR not linked to an issue yet — please open one first and claim it (see CONTRIBUTING) label Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: TestSprite/testsprite-cli/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 32ef6817-b0b6-4ae1-8d70-0cbae566a78f
📥 Commits

Reviewing files that changed from the base of the PR and between 988c035 and 56c23e8.

⛔ Files ignored due to path filters: 1
  • package-lock.json is excluded by !**/package-lock.json, !package-lock.json
📒 Files selected for processing: 13
  • BUG-FIXES.md
  • package.json
  • scripts/run-tests.mjs
  • src/commands/doctor.test.ts
  • src/commands/test.test.ts
  • src/lib/bundle.test.ts
  • src/lib/bundle.ts
  • src/lib/secret-file.test.ts
  • test/billing-refusal-render.subprocess.test.ts
  • test/cli.help.test.ts
  • test/helpers/fsModeEnforcement.ts
  • test/history-retention.subprocess.test.ts
  • test/tunnel-limit-render.subprocess.test.ts
+---------------------------------------------------------------------+
| Not saying it's bad... but the compiler just asked for a union rep. |
+---------------------------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@festac-dev festac-dev closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-issue PR not linked to an issue yet — please open one first and claim it (see CONTRIBUTING)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant