Repository navigation
Conversation
|
Thanks for the PR, @892041548! It links an issue, but that issue isn't assigned to you yet: #411 (unassigned). Per our workflow, claim the issue first by commenting |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
Walkthrough
ChangesSchedule update name validation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to
|
|
🏆 Season 4 CLI Improvement Bonus: entry recorded. Thanks, @892041548! To be counted, this PR needs the following by Oct 29, 11:59 PM PT:
Rewards go to merged PRs judged a genuine improvement, and up to three bonus-eligible PRs count per person. Untick the box to withdraw the entry. This comment refreshes when you edit the PR. Full rules. |
Season 4 CLI Improvement Bonus
What's broken (Closes #411)
schedule update --name ""bypasses the empty-name guard thatschedule createenforces, sending an empty name to the server (same class as #363 for--cron).How you found it
Differential probing of create vs update validation for the same flags.
Why it matters
An empty schedule name is never intentional; failing fast with exit 5 and a clear message beats a confusing server round-trip or a silently blank-named schedule. Complements PR #371 (which guards
--cronin the samerunUpdate);--nameverified still unguarded on main as of 2026-10-15.Tests
src/commands/schedule.test.ts(empty and whitespace-only--namerejected, no network call made)schedule.test.ts: 20 passed;tsc --noEmitclean; eslint 0 errorsSummary by CodeRabbit