Add host-side games module and CLI commands; add release-binaries CI workflow#4
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0ce3b2278
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
rust/src/games.rsimplementingball_game,pingpong_game,d20_game, andcoin_gamealong with unit tests and a simple LCG RNG helper.pub mod games;inlib.rsand wiring commands inrust/src/shell.rsincludingball,pong/pingpong,d20/dice, andcoin/flip, plus aprint_game_lineshelper and thorough argument validation forball.shellhelp text to list the new game commands..github/workflows/release-binaries.ymlwhich builds theminiosbinary for Linux, macOS, and Windows, packages per-OS archives, uploads artifacts, and attaches them to GitHub releases viaghon tag pushes.Testing
cargo testfor the Rust crate and the new unit tests which verify game outputs and shell command behavior, and all tests passed.ballcommand argument validation via unit tests that assert proper error messages and counts.Codex Task