Refactor KEX handling to async and offload X25519 crypto#159
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
==========================================
+ Coverage 53.90% 54.52% +0.61%
==========================================
Files 64 66 +2
Lines 5272 5357 +85
==========================================
+ Hits 2842 2921 +79
- Misses 2430 2436 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Collaborator
Author
|
I changed SSH transport packet processing to be asynchronous, and I moved X25519 key exchange off the main isolate to avoid UI blocking. This changes the timing of handshake and packet handling; other key exchange algorithms still run synchronously. |
…rformance and responsiveness
…ample with record types
…ts for X25519, DH, and NIST curves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related issue #23
Why
Addresses UI/main-isolate blocking reported in issue #23 by moving the heaviest X25519 operations off the main isolate and allowing async handling in the transport path.
Testing