Conversation
Owner
|
Hi @rdong8 , thank you for your PR. It took me a while, but I had a look at your pr. I like the idea, but I wanted to make it a bit more "bazel-like" and less reliant on shell commands. Playing a bit with the Doxyfile configuration lead me to discover what I believe to be a bug in Doxygen itself, which I have reported here. I would like to wait for it to be fixed, and then merge this pr, maybe slightly modified, as well as some other minor changes that I noticed going through the code. |
Contributor
Author
|
Sounds good, thanks for taking a look! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
dot_executablehandling and makes it work with the new graphviz module in the BCR. Updates the graphviz example and its documentation to demo it and more clearly distinguish between what you do to use a hermetic graphviz like@graphvizor use a non-hermetic one installed on the host.