fix(knowledge): align citations with context budget - #1491
Open
AbelTomato wants to merge 2 commits into
Open
AbelTomato wants to merge 2 commits into
AbelTomato wants to merge 2 commits into
Conversation
dangzitou
reviewed
Oct 3, 2026
dangzitou
left a comment
dangzitou
left a comment
Contributor
There was a problem hiding this comment.
本地核验通过：PR 分支 3 个用例全绿；新用例拷回 develop 红（develop 上引用 marker 确实包含未注入上下文的文档）。continue 跳过的空文本 chunk 也一并不再被引用，CHANGELOG 已补。
非阻塞：CHANGELOG.md 与 develop 有冲突，合入前需要 rebase 一下。代码内容未发现其他问题。
AbelTomato
marked this pull request as ready for review
October 4, 2026 03:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1490
When the knowledge retrieval context is truncated by
char_budget, citation markers could include ranked documents whose content was not injected into the contextTarget branch
develop(feature / fix — default)main(release/*orhotfix/*only)Type of change
Test plan
make allpasses locallyChecklist
CHANGELOG.md(if user-facing)