Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A custom provider can be saved with a URL as its name (e.g.
https://api.openai.com/), but every subsequent model operation on that provider fails — e.g. "Set as preferred model" returns 400:{"error": {"code": "SLASH_BAD_ARGS", "message": "Invalid arguments."}}Root cause
Model refs have the form <provider_name>/<model_id> and are parsed with str.partition("/") (infra/agents/providers/store.py). When the provider name itself contains /, the split is wrong, the provider lookup always
misses, is_model_ref_usable() returns False, and the request is rejected with 400.
None of the three creation entry points (admin API, setup wizard, CLI) validated the name, so such names could be persisted.
Fix
Tests