Fix Vulkan fallback crash with empty optional inputs - #6870
Open
futz12 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a crash in mixed Vulkan/CPU execution when a CPU fallback layer has an optional input that is empty on both the
host and Vulkan sides.
Problem
When a layer does not support Vulkan, ncnn downloads its Vulkan inputs before executing the layer on CPU.
For optional inputs, such as an empty K/V cache during the first decoder step of
MultiHeadAttention, both the hostMatand GPUVkMatmay be empty.The existing fallback code only checked whether the destination was empty and then attempted to transfer from an empty
source:
This caused an access violation on Windows (0xC0000005) when record_download() received an empty VkMat.
The same issue could occur in the opposite host-to-Vulkan direction.
Fix
Only record a transfer when the destination is empty and the source actually exists:
If both sides are empty, the input remains empty and is passed to the layer as an optional input.
Validation
Tested with a translation encoder/decoder graph where int8 MultiHeadAttention falls back to CPU while other layers run
on Vulkan.
Verified: