[rdeago]

Checklist of related issues / discussions

• Closes #
• Part of Remove the null-forgiving operators from src/ #408
• Related discussion(s): #

Proposed changes

#408 asks whether an analyzer can report the null-forgiving operator (!), so that the rule against it needs no review to enforce it. Nullable.Extended.Analyzer reports every null-forgiving operator as a warning. A comment that starts with // !, on the line above the statement, clears the warning and states the invariant.

This PR adds the analyzer to Buildvana SDK, and prepares this repository for the removal of its operators. The removal comes in a second PR. Buildvana builds itself with the last published release of its own packages, so the analyzer reaches this repository only after a release.

Buildvana SDK

The StandardAnalyzers module has a fourth switch, UseNullableExtendedAnalyzer. It follows UseStyleCopAnalyzers:

• The default is true, except for a project that uses the Microsoft.Build.NoTargets SDK.
• A value MSBuild reads as true, such as yes, counts as true, and any other value counts as false.
• When the switch is true, Module.UseNullableExtendedAnalyzer.targets adds a PackageReference to Nullable.Extended.Analyzer with PrivateAssets="All".

PackageVersions.props pins the package at 1.18.2. docs/sdk-modules/standard-analyzers.md documents the switch, the four rules NX0001 to NX0004, and the // ! comment.

The change is breaking. A project with a null-forgiving operator and no // ! comment gets a warning it did not get before, and an error when it treats warnings as errors.

This repository

• .globalconfig has a section for Nullable.Extended.Analyzer. It lists NX0001 to NX0004 at warning, the default severity.
• Common.props sets UseNullableExtendedAnalyzer to false. The repository holds about 50 operators under src/ and about 470 lines with one under tests/, none with a // ! comment. Without the setting, the first build with the next release of Buildvana SDK would fail. The second PR removes the setting.
• .claude/scratchpad/Common.props sets UseNullableExtendedAnalyzer to false for good. Scratch code is not held to the rule.

MCP server

dotnet-tools.json adds Nullable.Extended.Mcp 1.18.2 as a local tool. .mcp.json, at the root of the repository, runs it as an MCP server, with --root . and --solution Buildvana.slnx. The server finds the null-forgiving operators of the solution from the syntax, without a build. The second PR uses it to survey the operators and plan their removal.

Additional changes

• Tests of the StandardAnalyzers module. StandardAnalyzersModuleTargetsTests covers every switch and default of Module.targets, not only UseNullableExtendedAnalyzer. A regression in EnableNETAnalyzers, AnalysisLevel, AnalysisMode, EnforceCodeStyleInBuild, UseStyleCopAnalyzers, UsePublicApiAnalyzers, or the search for stylecop.json used to pass the build.
• .globalconfig section headers. The StyleCop and public API sections warned against setting severities in .DotSettings files. Only ReSharper reads those files, so the warning belongs in the ReSharper section of .editorconfig alone.

Types of changes

This pull request introduces the following types of changes:

• Bug fix
• New feature
• Test addition / update (no changes to non-test code)
• Refactor (no changes in public API syntax or semantics)
• Performance improvement (no changes in public API syntax or semantics)
• Documentation update (not including changelog)
• Dependency addition / update
• Changes to toolchain configuration
• Changes to CI (workflows, bot / app configurations)
• Changes to repository files (.gitattributes, .gitignore)
• Other

Breaking changes

This pull request introduces breaking changes:

• Yes
• No

Checklist

• For all types of changes:
  • I have read the Code of Conduct and agree to be bound by it
  • I have read the Contributor Guide and agree to follow it
• For code changes only:
  • The project builds on my machine, via the provided build script, with zero warnings
  • I have added tests that prove my feature works / my fix is effective
  • I have added / modified XML documentation according to changes in code
  • I have checked that all the links I added or modified in XML documentation point to their intended destination
• For documentation changes only:
  • I have checked and proofread documentation locally
  • I have checked that all the links I added or modified point to their intended destination

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.28%. Comparing base (3191443) to head (2a0ab46).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   87.28%   87.28%           
=======================================
  Files         321      321           
  Lines        9514     9514           
  Branches     1793     1793           
=======================================
  Hits         8304     8304           
  Misses        911      911           
  Partials      299      299           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rdeago]

Review by Claude. Self-review.

⚠️ Changes requested.

---

No blocking findings.

Non-blocking

• PR text, "This repository" section. The first bullet says that the new .globalconfig section lists NX0001 to NX0004 at the default severity, "as the sections of the other analyzers do". The public API analyzers section does the opposite: its header says "We only list non-default severities here." Drop the comparison, or name only the sections that list every rule.

[rdeago]

It lists NX0001 to NX0004 at warning, the default severity, as the sections of the other analyzers do.

Fixed in the PR text. The bullet drops the comparison. No section of .globalconfig follows a policy of listing default severities, or of omitting them. The Nullable.Extended.Analyzer section lists warning because no rule needs another severity.

Two other changes:

• 28a3a90 fixes the rules table in docs/sdk-modules/standard-analyzers.md. NX0002 also covers default(T)!. NX0004 covers only the initializer of a property with an init accessor. null! inside a lambda expression gets NX0002, not NX0003.
• 2a0ab46 replaces the rule titles in the .globalconfig comments with the rule message, so a search for the text of a warning finds the line. The four rules share one message.

[rdeago]

Review by Claude. Self-review.

👍 Approved.

---

No blocking findings. The PR text no longer compares the Nullable.Extended.Analyzer section of .globalconfig with the other sections.