[rdeago]

Checklist of related issues / discussions

• Closes bv release talks to GitHub over HttpClient, and Octokit goes #403
• Part of Support any CI platform and any Git host in bv #402
• Related discussion(s): #

Proposed changes

GitHubServerAdapter reached the GitHub REST API through Octokit, whose base address is always https://api.github.com. A release on a GitHub Enterprise Server could not reach its own API. The other hosts that #402 adds have no Octokit either.

GitHubApiClient, in src/Buildvana.Tool/Services/ServerAdapters/Internal/GitHub/, replaces Octokit. It is a small client over HttpClient, with the operations GitHubServerAdapter calls:

• get the repository, for IsPrivateRepositoryAsync;
• create a draft release, generate its notes, edit it, and delete it;
• check whether a tag exists, and delete it;
• upload a release asset.

The API base URL follows the host of the origin remote. For github.com, it is https://api.github.com. Any other host is taken for a GitHub Enterprise Server, at https://<host>/api/v3.

Every request carries Accept: application/vnd.github+json, X-GitHub-Api-Version: 2022-11-28, Authorization: Bearer <token>, and a User-Agent with the name and version of bv. The request and response models are records, serialized through the source-generated GitHubJsonContext. An answer outside the 2xx range fails the build with the status code and the message of the body. A 404 on the tag lookup means that the tag does not exist.

GitHubServerAdapter holds one GitHubApiClient for its whole life. The service provider disposes the adapter, and the adapter disposes the client.

Where the code differs from the issue

• Upload URL. The issue derives the upload address: https://uploads.github.com for github.com, https://<host>/api/uploads otherwise. GitHubApiClient uses the upload_url that GitHub states in the answer to the creation of the release, as Octokit's UploadAsset does. The server then names its own upload address, and the client derives nothing it cannot measure.
• Asset label. The upload sends label in the query string, next to name. Octokit set the label with a second request, PATCH .../releases/assets/{id}, which is gone.
• Tag lookup. TagExistsAsync asks for git/ref/tags/<tag>, singular. Octokit asked for git/refs/tags/<tag>. When no tag matches exactly, that endpoint answers with every tag whose name starts with <tag>, so a missing tag could look present. The delete stays on git/refs/tags/<tag>, the only endpoint that deletes a reference.
• API version. X-GitHub-Api-Version stays 2022-11-28 instead of the more recent 2026-03-10, for compatibility with GitHub Enterprise Server 3.19 and 3.20. The remarks of GitHubApiClient.ApiVersion hold the reason and the possible version switch dates.

Tests

StubHttpMessageHandler answers by method and URL, with a status code, and records the method, the headers, and the body of each request.

GitHubApiClientTests covers every operation: the URL, the method, the headers, the body sent, and the value read from the answer. The error path covers a refusal of every operation, an answer without a message, an unreadable answer, an unreachable host, a timeout, and cancellation.

Risks

• A difference between what Octokit sent and what GitHubApiClient sends is invisible to a unit test. The first release after the merge will be the final test. A failure in the asset upload or in the publication of the release comes after the NuGet push. The rollback of bv release then removes the commits, the tag, and the GitHub release, but the packages stay on the feed.
• The GitHub Enterprise Server base URL is derived from GitHub's documentation, not measured. Buildvana has no such server to test against.

Additional changes

• IGitService. ServerRelease.DisposeAsync disposed GitService, a singleton that the service provider owns and disposes again at the end of the run. Every consumer held a GitService, so nothing told a borrowed service from an owned one. IGitService does not extend IDisposable, the service provider registers GitService under it, and every consumer depends on it. ServerRelease no longer disposes it.
• GitHubServerAdapter.IsCloudBuild. Its <value> documentation said that the property always returns false. The property returns true, and the documentation says so.
• DotNetReleaseIndex.ReadJsonAsync. It returned from inside an await using block, within a try block. The coverage report then counted the closing brace of the try block as a line that no test runs. The method now returns after the try block, as the methods of GitHubApiClient do.

Types of changes

This pull request introduces the following types of changes:

• Bug fix
• New feature
• Test addition / update (no changes to non-test code)
• Refactor (no changes in public API syntax or semantics)
• Performance improvement (no changes in public API syntax or semantics)
• Documentation update (not including changelog)
• Dependency addition / update
• Changes to toolchain configuration
• Changes to CI (workflows, bot / app configurations)
• Changes to repository files (.gitattributes, .gitignore)
• Other

Breaking changes

This pull request introduces breaking changes:

• Yes
• No

Checklist

• For all types of changes:
  • I have read the Code of Conduct and agree to be bound by it
  • I have read the Contributor Guide and agree to follow it
• For code changes only:
  • The project builds on my machine, via the provided build script, with zero warnings
  • I have added tests that prove my feature works / my fix is effective
  • I have added / modified XML documentation according to changes in code
  • I have checked that all the links I added or modified in XML documentation point to their intended destination
• For documentation changes only:
  • I have checked and proofread documentation locally
  • I have checked that all the links I added or modified point to their intended destination

🤖 Generated with Claude Code

[codecov]

Codecov Report

❌ Patch coverage is 80.12048% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.37%. Comparing base (db19ae2) to head (04ca2d0).

Files with missing lines	Patch %	Lines
...verAdapters/Internal/GitHub/GitHubServerAdapter.cs	0.00%	32 Missing ⚠️
...c/Buildvana.Tool/Subcommands/VersionShowCommand.cs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   82.97%   83.37%   +0.39%     
==========================================
  Files         284      285       +1     
  Lines        8359     8473     +114     
  Branches     1645     1654       +9     
==========================================
+ Hits         6936     7064     +128     
+ Misses       1146     1132      -14     
  Partials      277      277              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[rdeago]

Review by Claude. Self-review.

⚠️ Changes requested.

---

One finding. It comes from the failed codecov/patch check, on the added file GitHubApiClient.cs.

[rdeago]

Review by Claude. Self-review.

👍 Approved.

---

No blocking findings. The two fixes for the finding of the previous round hold at the head commit.