Introduce SimulatorOptions and SimulatorKwargs#569
Open
thierry-martinez wants to merge 2 commits into
Open
Conversation
This commit introduces `SimulatorOptions` and `SimulatorKwargs` to group the keyword arguments of `Simulator`. This reduces code duplication and allows the arguments to `simulate_pattern` to be type-checked.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #569 +/- ##
==========================================
+ Coverage 90.58% 90.61% +0.02%
==========================================
Files 49 49
Lines 7481 7493 +12
==========================================
+ Hits 6777 6790 +13
+ Misses 704 703 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pranav97nair
approved these changes
Jul 22, 2026
pranav97nair
left a comment
pranav97nair
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this nice addition and for teaching me about Unpack!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces
SimulatorOptionsandSimulatorKwargsto group the keyword arguments ofSimulator.This reduces code duplication and allows the arguments to
simulate_patternto be type-checked.