Repository navigation
fix(tangent): wrap the attach-agent command instead of scrolling it - #3005
Merged
Merged
Conversation
The command sat in a fixed one-line box that scrolled sideways, so on systems with always-visible scrollbars the scrollbar covered the text. It now wraps, breaking inside long tokens so the dialog keeps its width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🎩 PreviewA preview build has been created at: |
Mbeaulne
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Make the attach command in the Attach an agent dialog readable on small screens, so people can see the command they are about to copy.
Current behavior
The command sits in a one-line box that scrolls sideways. On systems that always show scrollbars, the scrollbar fills that box and covers the command, so all you see is a grey bar. With overlay scrollbars, you only see the start of the command.
What changes
The command now wraps onto as many lines as it needs. Where there is no space to break at, it breaks inside the URL or session ID. The box grows to fit, and the dialog keeps its normal width. The copy button still copies the command as a single line.
The VS Code extension install command in Settings uses the same component and still scrolls sideways. That is unchanged because its scrollbar sits below the text, not over it.
How to test
I took the screenshots below from a local page that renders the real dialog in a 420px-wide Chromium window with scrollbars shown. The URL and session ID are placeholders. At 1280px wide, the dialog stayed 384px wide on all four tabs, with no sideways overflow. The existing dialog unit tests and lint pass. I did not test inside a live project.
Related Issue and Pull requests
Closes https://github.com/Shopify/oasis-frontend/issues/773
Type of Change
Line Breakdown
Checklist
Screenshots (if applicable)
Additional Comments
The fixed-height, absolutely positioned wrapper is gone. It existed only so the long command would not widen the dialog, and breaking inside long words does that job now. The
containedprop is renamed towrapto match what it does. The attach dialog was its only user.🤖 Generated with Claude Code