Repository navigation
Conversation
🎩 PreviewA preview build has been created at: |
camielvs
changed the title
camielvs
force-pushed
the
cvs/embedded-view-only-menu-bar
branch
3 times, most recently
from
November 5, 2026 16:38
af201e9 to
f6021e9
Compare
camielvs
commented
Nov 5, 2026
camielvs
left a comment
camielvs
left a comment
Collaborator
Author
There was a problem hiding this comment.
🤖 This is an AI-generated code review comment.
2 low-severity findings, inline below. Otherwise this looks clean: extracting ReadOnlyBadge keeps the label in one place, the xyflow Panel sits below the in-flow breadcrumb strip and under floating windows, and the exact button count in the new test stops the AI model picker from coming back.
camielvs
force-pushed
the
cvs/embedded-view-only-menu-bar
branch
from
November 6, 2026 16:07
75635ef to
330a458
Compare
…av bar A pipeline you can't edit, opened in a Tangent tab, rendered the standalone page's whole menu bar inside the tab: the home logo, the pipeline name and every app-wide button, stacked under the app's own nav. When embedded, drop the bar and float what the app's nav lacks (the View only badge, the View and Windows menus, and the AI model picker) in the canvas's top-right corner. The standalone page keeps its bar. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Tangent's chat has its own model picker, so a second one floating on the canvas would be confusing. The floating controls keep only the View only badge and the View and Windows menus. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rename the badge from "View only" on both the floating controls and the standalone pipeline page, sharing one ReadOnlyBadge so the two can't drift. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The embedded read-only view copied the shell's root element, and the floating controls box repeated the menu bar's background. Extract RemotePipelineFrame for the former and export CANVAS_MENU_SURFACE_CLASS for the latter, so both surfaces stay in step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
camielvs
force-pushed
the
cvs/embedded-view-only-menu-bar
branch
from
November 6, 2026 16:22
330a458 to
3036f53
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
People working in Tangent shouldn't see two nav bars when they open a pipeline they can't edit.
Current behavior
If you open a pipeline you can't edit in a Tangent tab, it brings along the menu bar from its standalone page. A second dark bar then sits under the app's own nav. It repeats the home logo, the pipeline name (already shown on the tab) and the app-wide buttons such as Onboarding, notices, settings and help. Pipelines you can edit open in Tangent with no bar at all, and so do runs.
What changes
In Tangent, a pipeline you can't edit now loses its menu bar and starts directly under the tab, the same as an editable pipeline. Only the controls that belong to this view float in a small dark box in the top-right corner of the canvas:
The box stays inside the canvas: inside a subgraph it sits below the breadcrumb strip, and floating windows open on top of it. The standalone pipeline page keeps its full menu bar.
The badge now says Read only instead of View only, in Tangent and on the standalone page.
How to test
You need a pipeline someone else owns, so that it opens as read only.
Unit and integration tests for the read-only pipeline view and the pipeline editor route pass (59), and lint and formatting are clean. The UI steps above weren't run against a live app. The local type check fails only in files this PR doesn't touch, because an installed dependency is out of date.
Related Issue and Pull requests
Follows #2965, which gave this view a compact layout in Tangent but kept its menu bar.
Type of Change
Line Breakdown
Checklist
Additional Comments
The box is dark so it can reuse the old bar's menu buttons as they are, since they're styled for a dark background. A light box would need a new light version of those buttons.
🤖 Generated with Claude Code