Skip to content

Move VS Code SSO callback off port 3001 #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
camielvs wants to merge 1 commit into from
Closed

Move VS Code SSO callback off port 3001 #2996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ VITE_OKTASSO_TOKEN_EXCHANGE_URL=
VITE_OKTASSO_CLIENT_ID=
VITE_OKTASSO_TOKEN_COOKIE_NAME=
VITE_OKTASSO_SCOPES=profile email openid
VITE_OKTASSO_REDIRECT_URI=http://localhost:3001/auth
VITE_OKTASSO_CALLBACK_PORT=3001
VITE_OKTASSO_REDIRECT_URI=http://localhost:31337/auth
VITE_OKTASSO_CALLBACK_PORT=31337
VITE_OKTASSO_REFRESH_AFTER_MS=3300000

# Github
Expand Down
4 changes: 2 additions & 2 deletions vscode-extension/src/auth/oktaSsoConfig.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ test("falls back to the documented defaults for optional settings", () => {
clearEnv();
const config = getOktaSsoConfig();
assert.equal(config.scopes, "profile email openid");
assert.equal(config.redirectUri, "http://localhost:3001/auth");
assert.equal(config.callbackPort, 3001);
assert.equal(config.redirectUri, "http://localhost:31337/auth");
assert.equal(config.callbackPort, 31337);
assert.equal(config.refreshAfterMs, 3_300_000);
});

Expand Down
4 changes: 2 additions & 2 deletions vscode-extension/src/auth/oktaSsoConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const DEFAULT_SCOPES = "profile email openid";
const DEFAULT_REDIRECT_URI = "http://localhost:3001/auth";
const DEFAULT_CALLBACK_PORT = 3001;
const DEFAULT_REDIRECT_URI = "http://localhost:31337/auth";
const DEFAULT_CALLBACK_PORT = 31337;
const DEFAULT_REFRESH_AFTER_MS = 3_300_000;

export interface OktaSsoConfig {
Expand Down
Loading