Conversation
…e nesting and wrap with top-level describe
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughThe PR restructures TypeScript type test files in angular-query-experimental by consolidating tests under unified top-level describe blocks, reorganizing existing test cases into nested structures, and adding new type-assertion cases for structural sharing, initialData function patterns, and discriminated union narrowing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
View your CI Pipeline Execution ↗ for commit 337be3b
☁️ Nx Cloud last updated this comment at |
🚀 Changeset Version PreviewNo changeset entries found. Merging this PR will not cause a version bump for any packages. |
size-limit report 📦
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/angular-query-experimental/src/__tests__/inject-query.test-d.ts`:
- Line 37: Update the test title string in the it(...) block that currently
reads "should be possible to define a different TData than TQueryFnData using
select with queryOptions spread into useQuery" to replace "useQuery" with
"injectQuery" so the test description matches the actual API under test (the
it(...) block for injectQuery in the inject-query.test-d.ts file).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3d253a68-d7f4-4f43-9b87-c391247cbf74
📒 Files selected for processing (3)
packages/angular-query-experimental/src/__tests__/inject-query.test-d.tspackages/solid-query/src/__tests__/useQuery.test-d.tsxpackages/svelte-query/tests/createQuery.test-d.ts
| expectTypeOf(data).toEqualTypeOf<Signal<{ wow: boolean }>>() | ||
| }) | ||
|
|
||
| it('should be possible to define a different TData than TQueryFnData using select with queryOptions spread into useQuery', () => { |
There was a problem hiding this comment.
Fix test title naming mismatch (useQuery → injectQuery).
Line 37 mentions useQuery, but this suite validates injectQuery; update the title to avoid misleading test output.
✏️ Suggested text fix
- it('should be possible to define a different TData than TQueryFnData using select with queryOptions spread into useQuery', () => {
+ it('should be possible to define a different TData than TQueryFnData using select with queryOptions spread into injectQuery', () => {📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| it('should be possible to define a different TData than TQueryFnData using select with queryOptions spread into useQuery', () => { | |
| it('should be possible to define a different TData than TQueryFnData using select with queryOptions spread into injectQuery', () => { |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/angular-query-experimental/src/__tests__/inject-query.test-d.ts` at
line 37, Update the test title string in the it(...) block that currently reads
"should be possible to define a different TData than TQueryFnData using select
with queryOptions spread into useQuery" to replace "useQuery" with "injectQuery"
so the test description matches the actual API under test (the it(...) block for
injectQuery in the inject-query.test-d.ts file).
…nject-queries.test-d.ts' and 'inject-mutation.test-d.ts'
sukvvon
changed the title
sukvvon
changed the title
1 participant
🎯 Changes
inject-query.test-d.tswith top-leveldescribe('injectQuery'), adddescribe('initialData')nesting, and nestDiscriminated union return typeinsideinject-mutation.test-d.tswithdescribe('injectMutation')and nestDiscriminated union return typeinsideinject-queries.test-d.tswithdescribe('injectQueries')and nestconfig object overloadinside✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit