Skip to content

fix(create): missing header/footer in router template#426

Open
ouvreboite wants to merge 1 commit intoTanStack:mainfrom
ouvreboite:patch-1
Open

fix(create): missing header/footer in router template#426
ouvreboite wants to merge 1 commit intoTanStack:mainfrom
ouvreboite:patch-1

Conversation

@ouvreboite
Copy link
Copy Markdown

@ouvreboite ouvreboite commented Apr 8, 2026

They seems to have been remove in february's refactoring. Without the header/footer the quick start instructions on the index page (ex: "Update src/components/Header.tsx and src/components/Footer.tsx for brand links.") makes little sense

Summary by CodeRabbit

  • New Features
    • Updated the default React project template to include Header and Footer components in the root layout. These components are now automatically rendered at the top and bottom of all application content, establishing a consistent UI structure for newly created React projects.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

📝 Walkthrough

Walkthrough

Header and Footer components are imported and rendered in the root layout template, wrapping the main routed content. Both router-only and document-based rendering paths include these new UI elements with no behavioral logic changes.

Changes

Cohort / File(s) Summary
Root Layout Template
packages/create/src/frameworks/react/project/base/src/routes/__root.tsx.ejs
Added Header and Footer component imports and JSX rendering around main content in both routerOnly and RootDocument paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A little hop and here we go,
Headers bloom and footers show,
Layout dance, so neat and tight,
Root wrapped up in pure delight!
Up and down, the frame takes flight,

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: adding missing Header and Footer components to the router template in the create package.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ouvreboite ouvreboite changed the title Fix missing header/footer in router template fix: missing header/footer in router template Apr 8, 2026
@ouvreboite ouvreboite changed the title fix: missing header/footer in router template fix(create): missing header/footer in router template Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant