Skip to content

Rectify: Provenance-Bound Audit-Cycle Delivery and Inventory-Gate Immunity#4348

Merged
Trecek merged 89 commits into
developfrom
impl-rectify_audit_cycle_delivery_immunity_2026-07-23_115040-20260723-163655
Jul 27, 2026
Merged

Rectify: Provenance-Bound Audit-Cycle Delivery and Inventory-Gate Immunity#4348
Trecek merged 89 commits into
developfrom
impl-rectify_audit_cycle_delivery_immunity_2026-07-23_115040-20260723-163655

Conversation

@Trecek

@Trecek Trecek commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Issue #4185 is a contract-boundary failure spanning recipe input binding, runtime delivery, audit authority, plan dispositions, semantic validation, and executable stateful coverage.

This implements a compile-once, provenance-bound audit-cycle protocol. Recipe admission now separates MCP parameters from named child-skill inputs; audit verdicts emit content-addressed authority; make-plan emits plan-bound dispositions; dry-walkthrough independently verifies authority and lifecycle; stale or mismatched authority is rejected; and semantic rules inspect the same bound invocation and resolved artifacts used at runtime.

Implementation Plan

Plan file: /home/talon/projects/generic_automation_mcp/.autoskillit/temp/rectify/rectify_audit_cycle_delivery_immunity_2026-07-23_115040.md

🤖 Generated with Claude Code via AutoSkillit

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: approved_with_comments

Comment thread src/autoskillit/core/audit_cycle_verifier.py Outdated
Comment thread src/autoskillit/core/path_containment.py
Comment thread src/autoskillit/core/types/_type_audit_cycle.py
Comment thread src/autoskillit/recipe/_binding.py Outdated
Comment thread src/autoskillit/recipe/_contracts_types.py Outdated
Comment thread src/autoskillit/server/_recipe_execution.py Outdated

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.

@Trecek
Trecek force-pushed the impl-rectify_audit_cycle_delivery_immunity_2026-07-23_115040-20260723-163655 branch from 70910b0 to b3ea23a Compare July 25, 2026 16:49

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested (self-authored PR; GitHub records this as COMMENT)

Comment thread src/autoskillit/core/path_containment.py Outdated
Comment thread src/autoskillit/core/types/_type_audit_cycle.py
Comment thread src/autoskillit/recipe/_binding.py
Comment thread src/autoskillit/server/_recipe_execution.py Outdated
Comment thread src/autoskillit/server/tools/tools_execution.py Outdated
Comment thread tests/server/test_tool_registry_parity.py

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking findings detected. See inline comments. Verdict is changes_requested; GitHub cannot record REQUEST_CHANGES on a self-authored PR.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested

Comment thread src/autoskillit/server/tools/tools_recipe.py
Comment thread src/autoskillit/server/tools/tools_execution.py Outdated
Comment thread src/autoskillit/core/types/_type_recipe_execution.py
Comment thread src/autoskillit/server/_recipe_delivery.py Outdated
Comment thread src/autoskillit/recipe/_api.py

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking findings detected. See inline comments for required changes.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested

Comment thread tests/server/test_audit_cycle_delivery_integration.py Outdated
Comment thread tests/server/test_audit_cycle_delivery_integration.py
Comment thread tests/server/test_audit_cycle_delivery_integration.py
Comment thread tests/contracts/test_review_pr_diff_annotation.py Outdated
Comment thread src/autoskillit/server/_recipe_execution.py
Comment thread src/autoskillit/server/_recipe_execution.py Outdated
Comment thread src/autoskillit/recipes/implementation-groups.json Outdated
Comment thread src/autoskillit/recipes/research-implement.json Outdated
Comment thread src/autoskillit/core/types/_type_recipe_binding.py
Comment thread src/autoskillit/recipe/io.py Outdated

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking findings detected. See the inline comments. This review is posted as COMMENT because GitHub does not allow the authenticated PR-author account to submit REQUEST_CHANGES on its own pull request.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: approved_with_comments

Comment thread src/autoskillit/core/types/_type_audit_cycle.py
Comment thread src/autoskillit/core/types/_type_recipe_binding.py
Comment thread src/autoskillit/pipeline/context.py Outdated
Comment thread src/autoskillit/recipe/_binding.py Outdated
Comment thread src/autoskillit/recipe/io.py Outdated
Comment thread src/autoskillit/server/_recipe_execution.py Outdated
Comment thread src/autoskillit/server/_recipe_execution.py Outdated
Comment thread src/autoskillit/server/tools/tools_kitchen.py Outdated
Comment thread src/autoskillit/server/tools/tools_recipe.py Outdated
Comment thread tests/server/test_audit_cycle_delivery_integration.py Outdated

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: changes_requested

Comment thread src/autoskillit/core/audit_cycle_verifier.py
Comment thread src/autoskillit/core/tool_registry.py
Comment thread src/autoskillit/core/types/_type_audit_cycle.py
Comment thread src/autoskillit/core/types/_type_audit_cycle.py
Comment thread src/autoskillit/core/types/_type_recipe_binding.py Outdated
Comment thread src/autoskillit/server/_recipe_execution.py
Comment thread src/autoskillit/server/_recipe_execution.py Outdated
Comment thread src/autoskillit/server/_recipe_execution.py Outdated
Comment thread src/autoskillit/server/_recipe_execution.py Outdated
Comment thread src/autoskillit/server/tools/tools_execution.py Outdated

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: blocking findings detected. See the inline comments; the critical audit-cycle lineage bypass must be fixed before this PR is ready.

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit PR Review — Verdict: approved_with_comments

Comment thread tests/server/test_audit_cycle_delivery_integration.py
Comment thread src/autoskillit/core/tool_registry.py
Comment thread src/autoskillit/core/types/_type_recipe_binding.py
Comment thread src/autoskillit/recipe/_contracts_manifest.py
Comment thread src/autoskillit/recipe/_cmd_rpc_guards.py Outdated

@Trecek Trecek left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.

@Trecek
Trecek force-pushed the impl-rectify_audit_cycle_delivery_immunity_2026-07-23_115040-20260723-163655 branch from 00850c4 to 0e77ed4 Compare July 27, 2026 02:32
@Trecek
Trecek added this pull request to the merge queue Jul 27, 2026
Merged via the queue into develop with commit c601e2e Jul 27, 2026
3 checks passed
@Trecek
Trecek deleted the impl-rectify_audit_cycle_delivery_immunity_2026-07-23_115040-20260723-163655 branch July 27, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant