Rectify: Shell Capture Filesystem Trust Anchor#4342
Conversation
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: changes_requested
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: blocking findings detected. See inline comments. GitHub does not permit the PR author to submit a request-changes review on their own PR, so this was submitted as a comment review; verdict remains changes_requested.
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: changes_requested
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: blocking findings detected. Changes are requested; see the inline comments.
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved_with_comments
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved_with_comments
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.
1 participant
Summary
Issue #4319 is not only a missing symlink check. The shell-capture lifecycle lacks a stable filesystem authority.
shell_capture_hook.pyaccepts an absolutecwd, builds<cwd>/.autoskillit/temp/shell_captureby pathname, and the generated Bash harness creates, redirects to, measures, hashes, replays, and reports the artifact by reopening that path.session_start_hook.pythen performs cleanup through a separate pathname-only implementation._capture_cleanup.pyis tested, but it is not used by the registered SessionStart hook and it trusts a resolved symlinked root.Closes #4319
Implementation Plan
Plan file:
/home/talon/projects/generic_automation_mcp/.autoskillit/temp/rectify/rectify_shell_capture_trust_anchor_2026-07-22_185019.md🤖 Generated with Claude Code via AutoSkillit