Skip to content

Hide SQLite virtual table internals - #624

Open
DhruvShah-Dev wants to merge 1 commit into
TabularisDB:mainfrom
DhruvShah-Dev:fix/sqlite-hidden-virtual-columns
Open

Hide SQLite virtual table internals#624
DhruvShah-Dev wants to merge 1 commit into
TabularisDB:mainfrom
DhruvShah-Dev:fix/sqlite-hidden-virtual-columns

Conversation

@DhruvShah-Dev

Copy link
Copy Markdown
Contributor

Summary

  • Filters SQLite table_xinfo rows with hidden = 1 out of column metadata.
  • Keeps generated columns visible by continuing to expose hidden = 2 and hidden = 3 as generated metadata.
  • Adds FTS5 coverage for direct and batch SQLite column metadata lookups.

Root Cause

PRAGMA table_xinfo includes hidden virtual-table columns that table_info did not return. Those rows were mapped as normal writable columns and surfaced in the New Row modal.

Fixes #622

Validation

  • git diff --check
  • cargo test test_get_columns_excludes_hidden_virtual_table_columns --lib -- --nocapture timed out locally after 3 minutes during Rust execution/build.

@DhruvShah-Dev
DhruvShah-Dev marked this pull request as ready for review August 11, 2026 17:30
@kilo-code-bot

kilo-code-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • src-tauri/src/drivers/sqlite/mod.rs
  • src-tauri/src/drivers/sqlite/tests.rs

Reviewed by glm-5.2 · Input: 102.8K · Output: 7.8K · Cached: 96.4K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: hidden columns of virtual tables show up as editable fields in the New Row modal

1 participant