Hide SQLite virtual table internals - #624
Open
DhruvShah-Dev wants to merge 1 commit into
Open
Conversation
DhruvShah-Dev
marked this pull request as ready for review
August 11, 2026 17:30
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by glm-5.2 · Input: 102.8K · Output: 7.8K · Cached: 96.4K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table_xinforows withhidden = 1out of column metadata.hidden = 2andhidden = 3as generated metadata.Root Cause
PRAGMA table_xinfoincludes hidden virtual-table columns thattable_infodid not return. Those rows were mapped as normal writable columns and surfaced in the New Row modal.Fixes #622
Validation
git diff --checkcargo test test_get_columns_excludes_hidden_virtual_table_columns --lib -- --nocapturetimed out locally after 3 minutes during Rust execution/build.