feat: support all monospaced fonts installed on the local system#647
Merged
datlechin merged 4 commits intoTableProApp:mainfrom Apr 9, 2026
Merged
feat: support all monospaced fonts installed on the local system#647datlechin merged 4 commits intoTableProApp:mainfrom
datlechin merged 4 commits intoTableProApp:mainfrom
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA. |
datlechin
requested changes
Apr 9, 2026
Collaborator
datlechin
left a comment
There was a problem hiding this comment.
Nice PR, but have few things to fix:
- isRecommended and displayName seem like definded but no read anywhere
- availableMonospacedFamilies() make it static let instead
Contributor
Author
|
Sorry about the extra properties. I had been trying out a couple different features I've been thinking about and forgot to |
Collaborator
|
Hi @nexxai, thanks for the quick update. Also, please update the tests as well. Currently, the test still has parentheses around |
Contributor
Author
|
Yeah, I guess that would be helpful to include in the commit too. |
datlechin
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I wanted to use a monospaced font that wasn't one of the 4 default included ones (specifically JetBrains Mono) but was obviously unable to as the list was hardcoded.
Solution
I replaced the hardcoded font option flow with a shared runtime resolver that discovers installed monospaced font families and uses them in both settings UI and runtime theme font resolution. The resolver keeps
System Monoas a safe default and fallback when a saved font is unavailable. Theme storage remains string-based and backward-compatible, and docs/tests were updated to cover dynamic listing and fallback behavior.This is my first contribution to this repo so if I'm missing anything, please let me know.