Fix support radius in zonotope.enclosePoints - #80
Open
suhaslord wants to merge 4 commits into
Open
Conversation
Collaborator
|
Dear @lili1039 and @suhaslord, Thank you so much for bringing this up (#79) and providing a solution alongside it here! We will investigate the bug a bit further and run it through our internal CI/CD pipeline, Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the support-radius calculation in
zonotope.enclosePointsand prevents azero generator from being normalized during residual-cloud compression.
Closes #79.
Problem
The previous implementation used
abs(dot(u,r)), whereris the nonnegativeradius vector of an axis-aligned interval and
uis the selected direction.Opposite signs in
ucan cancel even when the interval has nonzero extent. Forexample,
u = [-1; 1] / sqrt(2)andr = [1; 1]yield a zero dot product, afterwhich normalizing the zero generator introduces non-finite values.
Fix
dot(abs(u),r), the support radius of the axis-aligned interval in directionuValidation
dot(abs(u),r)equals the maximum absolute projection over the interval verticesmaster; only the implementation and focused unit test changegit diff --checksuccessfully