25 reintegrate hermes target sharing from targetdetail page#26
Open
phycodurus wants to merge 21 commits into
Open
25 reintegrate hermes target sharing from targetdetail page#26phycodurus wants to merge 21 commits into
phycodurus wants to merge 21 commits into
Conversation
as of this commit, the URL target is returning:
`Error code: 405 Method Not Allowed`
and move it to HERMES_CONFIGURATION. This separates HERMES from the data_sharing options drop-down menus whose menu-items are driven by the DATA_SHARING configurantion dict. HERMES sharing is sufficiently different to be handled separately.
- The POST originates from a TargetDetail button, not the sharing drop-down (as before). - The most notable change here is to resolve credentials with function `resolve_hermes_credentials`. - Add all data associated with Target and user can edit draft message on HERMES after they are redirected.
…arget-sharing-from-targetdetail-page
I think this came in as part of a merge conflict resolution that I bungled.
…arget-sharing-from-targetdetail-page
jchate6
requested changes
Jul 2, 2026
jchate6
left a comment
jchate6
left a comment
Contributor
There was a problem hiding this comment.
I have done a lot of work updating this code to be readable and functional with v3.
I didn't quite finish before I had to call it for the weekend.
If you do any work on this please let me know and push the results so I don't repeat any effort on Monday.
| self.extra_info = kwargs | ||
|
|
||
|
|
||
| def publish_to_hermes(message_info, datums, targets=None, *, user=None, **kwargs): |
Contributor
There was a problem hiding this comment.
I'm not sure where this is used.
| return message | ||
|
|
||
|
|
||
| def get_hermes_topics(*, user=None, **kwargs): |
Contributor
There was a problem hiding this comment.
I don't think this is used anymore either, but it may be someday...
| and `DEFAULT_TOPIC` if you want messages to default to a topic other than `'tomtoolkit.test'`. | ||
|
|
||
| ### Custom Data | ||
| If you use custom data models, you can also create your own `DATA_CONVERTER_CLASS`. This setting should be the dot separated path to a class that converts your custom `ReducedDatum` or `Target` into a format understood by the [HERMES API](https://hermes.lco.global/about). |
Contributor
There was a problem hiding this comment.
Fill this out with an example of extending the existing HermesDataConverter
| return HttpResponseRedirect(load_url) | ||
|
|
||
|
|
||
| class TargetGroupingHermesPreloadView(SingleObjectMixin, View): |
Contributor
There was a problem hiding this comment.
I didn't get here yet.
This doesn't seem to do anything currently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
settings.HERMES_CONFIGURATIONresovle_hermes_credentials()to check profile, then settings for creds