Fix cadence strategies#1592
Open
moira-andrews wants to merge 29 commits into
Open
Conversation
…ad of the full cadence window start and end
…egies display expected response
…alidation errors, added a test for a completed observation to turn off the cadence
…ate-start-and-end-windows
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've merged both PR branches #1414 and #1492 of fixing and updating the cadence windows and the single time observations to match what SNEx does but generalized for anyone that would want to use our cadence strategy style. I have tested the recurring sequence with more than 24 hour cadence frequency and verified that it works as expected. This also adds a new cadence strategy that differentiates between "single time observation, retry until successful" and "single time observation, give up after cadence frequency expires".
I've also updated the test_cadences.py to match and test the behavior of the updated cadence strategies.