1587 fix issue with simple fields on update form#1589
Conversation
jchate6
requested review from
Fingel and
phycodurus
and removed request for
phycodurus
| advanced_form = form.get_advanced_form_partial() | ||
|
|
||
| context['simple_fields'] = [] | ||
| if not simple_form and form.simple_fields(): |
There was a problem hiding this comment.
Why would the form not have as simple partial, but also have simple fields?
I trust that this works, but it just reads a little strange.
There was a problem hiding this comment.
I describe this in the docs but I should definitely add a comment here.
Basically, there is a basic partial that takes the fields in simple_fields and makes a super basic form. OR you can can make a simple partial that does whatever you want. So if no partial is given, but there are simple fields we will just use those in the built in default partial.
There was a problem hiding this comment.
One would not necessarily expect there to be BOTH a simple_fields and a user made simple_partial, since the user made simple partial could be much more specific to the dataservice's form fields.
2 participants
There was some missing context from the update form for a dataservice query