cleanup ClassFileImporterAnnotationsTest and minor other locations - #1717
Open
StefanGraeber wants to merge 3 commits into
Open
StefanGraeber wants to merge 3 commits into
StefanGraeber wants to merge 3 commits into
Conversation
…stead of Collection<Annotation> Signed-off-by: Stefan Gräber <stefan.graeber@tngtech.com>
…sWarnings("unchecked") Signed-off-by: Stefan Gräber <stefan.graeber@tngtech.com>
…or cleanup Signed-off-by: Stefan Gräber <stefan.graeber@tngtech.com>
hankem
reviewed
Sep 13, 2026
|
|
||
| .hasNoExplicitlyDeclaredProperty("defaultValue1") | ||
| .hasStringProperty("defaultValue1", "defaultValue1"); | ||
| } |
Member
There was a problem hiding this comment.
If you wanted, you could still remove the two blank lines until the @Nested class' closing }.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This a small preparation change for #1382
ClassFileImporterAnnotationsTest will be extended with many more new test cases for TYPE_USE annotations.
To prepare these new tests, the test class is migrated to junit5, grouped into Nested test suites and the annotation assertions are extended with a new overload for simpler usage.
In addition to that, the productive JavaTypeCreationProcess gets some minor changes to method signatures to get rid of uncheck warnings (and their supressions)