Extract hardcoded UI, input, and picker strings into localization resources and fix dialog close buttons - #2519
Open
akihofuyuka wants to merge 4 commits into
Open
akihofuyuka wants to merge 4 commits into
akihofuyuka wants to merge 4 commits into
Conversation
akihofuyuka
force-pushed
the
pr/localize-a2
branch
from
November 4, 2026 12:51
63cceb0 to
75b2e63
Compare
4 of 5 tasks
- Localize liquid and wire options in TileWallPickerViewModel. - Localize hovered liquid text in MouseTile.
akihofuyuka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract remaining hardcoded UI, plugin dialog, input action strings, and picker option lists into Language.resx, reusing existing keys where applicable. Configure IsCloseButtonEnabled in TEditDialogService to prevent WPF-UI's default "Close" button from appearing on Yes/No and OK dialogs. No logic changes.
Context
Second batch of localization coverage across Categories A and B in #2507, covering remaining editor popups, plugin confirmation dialogs, input action registries, and picker option lists. Refs #2507.
Verification
Triggered plugin confirmation prompts (including "Remove All Chests" and "Player Map") to verify that confirmation popups display only the intended Yes and No options without leaking default Close buttons. Switched display language to
zh-Hans, opened right sidebar Filter and Tile Picker panels, selected Liquids and Wires dropdowns, and confirmed options render as 水/岩浆/蜂蜜/微光 and 红线/蓝线/绿线/黄线; hovered over liquid tiles in an active map and confirmed inspector extras display水: 255instead ofWater: 255.Reviewer Notes
The string extractions and option list bindings are mechanical migrations into Language.resx with no behavior changes. The scoped fix in TEditDialogService manages close button visibility across dialog types.