Skip to content

Update bsnes from upstream and skip CX4 firmware check - #4854

Open
AkiteruSDA wants to merge 3 commits into
TASEmulators:masterfrom
AkiteruSDA:upstream-sync-20261006
Open

AkiteruSDA wants to merge 3 commits into
TASEmulators:masterfrom
AkiteruSDA:upstream-sync-20261006

Conversation

@AkiteruSDA

@AkiteruSDA AkiteruSDA commented Oct 7, 2026 •

Copy link
Copy Markdown

dev build for branch | AkiteruSDA:upstream-sync-20261006

Just the couple of emulation-related commits from upstream:

  • 7d5aa1e656b9171524d01b1b22917197d8121cb4: fix horizontal offset in high-resolution offset-by-tile mode
  • 78474e5d39f58872dc21aca18cf9eb583b147fe7: CX4: Remove extra cycle on DMA to internal RAM (fixes excessive slowdown in Morph Moth fight)

I also realized the new core includes the CX4 firmware already, so there isn't much need to check for the firmware file. I considered updating the old bsnes core to include it as well, but didn't want to mess with things too much, especially for an old core.

Check if completed:

  • I have run any relevant test suites
  • I, the commit author, have read the contribution terms on licensing and generative AI (last updated 2026-09-20) and am compliant

- 7d5aa1e656b9171524d01b1b22917197d8121cb4: fix horizontal offset in high-resolution offset-by-tile mode
- 78474e5d39f58872dc21aca18cf9eb583b147fe7: CX4: Remove extra cycle on DMA to internal RAM (fixes excessive slowdown in Morph Moth fight)
The core already includes the CX4 data ROM, so no need to check for the firmware file.
@Morilli

Morilli commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

I also realized the new core includes the CX4 firmware already

Seems you're right about that, I wonder why the core even requests that firmware file in the first place then. Given that the data rom is supposedly math tables only I doubt there's different revisions either.

This still allows the user to provide a CX4 data ROM file if they want, matching upstream, but no need to warn if not since the core falls back on the data ROM internally.
@AkiteruSDA

Copy link
Copy Markdown
Author

Upstream seems to still check for hg51bs169.data.rom but silently falls back on the built in data ROM if not provided. I figure that's where the request comes from. There is only one version of the data ROM, so not sure how much of a difference that makes, but I tweaked the frontend to still allow for a firmware file just to match upstream's behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants