Repository navigation
Update bsnes from upstream and skip CX4 firmware check - #4854
Open
AkiteruSDA wants to merge 3 commits into
Open
AkiteruSDA wants to merge 3 commits into
AkiteruSDA wants to merge 3 commits into
Conversation
- 7d5aa1e656b9171524d01b1b22917197d8121cb4: fix horizontal offset in high-resolution offset-by-tile mode - 78474e5d39f58872dc21aca18cf9eb583b147fe7: CX4: Remove extra cycle on DMA to internal RAM (fixes excessive slowdown in Morph Moth fight)
The core already includes the CX4 data ROM, so no need to check for the firmware file.
Collaborator
Seems you're right about that, I wonder why the core even requests that firmware file in the first place then. Given that the data rom is supposedly math tables only I doubt there's different revisions either. |
This still allows the user to provide a CX4 data ROM file if they want, matching upstream, but no need to warn if not since the core falls back on the data ROM internally.
Author
|
Upstream seems to still check for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just the couple of emulation-related commits from upstream:
7d5aa1e656b9171524d01b1b22917197d8121cb4: fix horizontal offset in high-resolution offset-by-tile mode78474e5d39f58872dc21aca18cf9eb583b147fe7: CX4: Remove extra cycle on DMA to internal RAM (fixes excessive slowdown in Morph Moth fight)I also realized the new core includes the CX4 firmware already, so there isn't much need to check for the firmware file. I considered updating the old bsnes core to include it as well, but didn't want to mess with things too much, especially for an old core.
Check if completed: