Draft
Conversation
YoshiRulz
added
App: EmuHawk
This reverts commit c8af415.
This reverts commit 214f53a.
This reverts commit 02573e6.
…od that properly checks the autosave config option." This reverts commit 229b500.
This reverts commit 3dba90f.
…g-or-canceling flow even though not all asking and error handling is implemented yet. Also, fix: respect the cancel button." This reverts commit 479e281.
This reverts commit 9fd9195.
…slot is still broken on close and on TAStudio open." This reverts commit 199ae5e.
…eporting." This reverts commit ebbb693.
…rary file until writing has completed. Avoids crashing and prevents loss of data in the event of an exception mid-write." This reverts commit 4d8e8ba.
YoshiRulz
force-pushed
the
revert-filewriter
branch
from
e3107be to
a13dd2c
Compare
Contributor
|
I expect there were a significant number of conflicts to resolve here. I think the risk of new bugs due to incorrect conflict resolution plus the re-introduction of the issues fixed by that PR (such as closing when the user says to cancel due to unsaved changes) are worse than the potential for still undiscovered regressions in the PR you want to revert. And there isn't any new reason to expect more testing or review for it outside release, since the time it was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per #4400 (comment)
The idea is for a2e8eed + this changeset to have the same file state as [the ~200 commits less #4400] rebased onto 7b07976 edit: which I've also started on here.