Partial fix to DOSBox-X Mem leak#4715
Closed
SergioMartin86 wants to merge 7 commits intomasterfrom
Closed
Conversation
Collaborator
Author
|
This fix is ready for merge, btw |
| } | ||
|
|
||
| // Freeing up core's own resources | ||
| _libDOSBox.deInit(); |
Member
There was a problem hiding this comment.
This is pointless in practice. Any memory allocated within the waterbox should be destroyed by the waterboxhost. You're not allocating with a normal heap, you're allocating within the waterboxhost's memory block, which by the view of the host OS is already allocated fully by the waterboxhost and should be released by the waterboxhost. There's nothing in the core code to do here (the OS won't recognize free'ing in core code as actually freeing the memory, the memory is still allocated by the waterboxhost).
Collaborator
Author
There was a problem hiding this comment.
Right, I forgot about this
added 4 commits
April 26, 2026 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some measures to reduce leakage on the DOSBox-X core, as described in #4714
There's one more leak remaining we'll need to find eventually. Not sure it's DosBox or Bizhawk related