[Request] Map Hotkeys for layer disabling for more consoles.

[ReyVGM]

Right now you can only map hotkeys to disable layers when playing SNES and GB games.

I'm requesting for the same thing to be added for the other consoles with the option to disable background and sprite layers. I know the NES and Genesis have the option in their own settings menu when you have one of their games loaded, but they can't be mapped to a hotkey.

Thanks and hopefully this is something that can be implemented in the future!

---

Affected cores:

BizHawk/src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.Hardcore.cs

Lines 46 to 61 in f1dce89

	private static readonly Dictionary<Type, string[]> CoreGraphicsLayers = new()
	{
	[typeof(Atari2600)] = new[] { "ShowBG", "ShowPlayer1", "ShowPlayer2", "ShowMissle1", "ShowMissle2", "ShowBall", "ShowPlayfield" },
	[typeof(LibsnesCore)] = new[] { "ShowBG1_0", "ShowBG2_0", "ShowBG3_0", "ShowBG4_0", "ShowBG1_1", "ShowBG2_1", "ShowBG3_1", "ShowBG4_1", "ShowOBJ_0", "ShowOBJ_1", "ShowOBJ_2", "ShowOBJ_3" },
	[typeof(BsnesCore)] = new[] { "ShowBG1_0", "ShowBG2_0", "ShowBG3_0", "ShowBG4_0", "ShowBG1_1", "ShowBG2_1", "ShowBG3_1", "ShowBG4_1", "ShowOBJ_0", "ShowOBJ_1", "ShowOBJ_2", "ShowOBJ_3" },
	[typeof(WonderSwan)] = new[] { "EnableBG", "EnableFG", "EnableSprites", },
	[typeof(GPGX)] = new[] { "DrawBGA", "DrawBGB", "DrawBGW", "DrawObj", },
	[typeof(MGBAHawk)] = new[] { "DisplayBG0", "DisplayBG1", "DisplayBG2", "DisplayBG3", "DisplayOBJ" },
	[typeof(MSX)] = new[] { "DispBG", "DispOBJ" },
	[typeof(NES)] = new[] { "DispBackground", "DispSprites" },
	[typeof(O2Hawk)] = new[] { "Show_Chars", "Show_Quads", "Show_Sprites", "Show_G7400_Sprites", "Show_G7400_BG" },
	[typeof(PCEngine)] = new[] { "ShowBG1", "ShowOBJ1", "ShowBG2", "ShowOBJ2", },
	[typeof(Sameboy)] = new[] { "EnableBGWIN", "EnableOBJ" },
	[typeof(SMS)] = new[] { "DispBG", "DispOBJ" },
	[typeof(Snes9x)] = new[] { "ShowBg0", "ShowBg1", "ShowBg2", "ShowBg3", "ShowSprites0", "ShowSprites1", "ShowSprites2", "ShowSprites3", "ShowWindow", "ShowTransparency" },
	};

[YoshiRulz]

What are the layer names for GBA and TG-16? And are the names and orders for GB, Genesis, NES, and SNES satisfactory? Now's the time to change those as I'll be breaking compatibility with old hotkey configs.

[vadosnaprimer]

Is there a way to abstract away from layer names and let users figure out which key relates to which layer? Or is it better to unify layer names instead?

[ReyVGM]

What are the layer names for GBA and TG-16? And are the names and orders for GB, Genesis, NES, and SNES satisfactory? Now's the time to change those as I'll be breaking compatibility with old hotkey configs.

At least in my case, you can leave them with the same "generic" names as they are called right now (background layer, object layer, etc).

In the end it doesn't matter because we'll be able to configure the keys we want to them and that's what I'll exclusively use, so we're not going to be entering a menu to enable/disable names any longer.

Also, remember that at least with the Genesis core, there's an option to turn on/off the backdrop to any color you want (default 0xffff00ff, useful to rip graphics). So be sure to include that in the hotkeys too!

[YoshiRulz]

Is there a way to abstract away from layer names and let users figure out which key relates to which layer?

That's what I was planning, only having numbered hotkeys "Toggle 1st GFX/Sprite Layer", "Toggle 2nd GFX/Sprite Layer", etc. and putting the names somewhere else. The hotkey binds dialog has a tooltip feature but I'm not sure that that would be discoverable, and I don't think the UI generator can read the global Emulator at the moment.

Or is it better to unify layer names instead?

Both. If the SNES cores, for example, had the layers in a different order, that might be annoying. Having the names be slightly different doesn't really matter, but if they're all the same I think I'd be able to dedup the implementations better.

---

Also, remember that at least with the Genesis core, there's an option to turn on/off the backdrop to any color you want (default 0xffff00ff, useful to rip graphics). So be sure to include that in the hotkeys too!

I hadn't considered that. "BG colour override" should always be the first layer—or maybe separate from the list. I can't find the Issue for standardising that, there's only #1642. Maybe I never actually opened one.

In any case I think #1652 (GPGX missing layers) is blocking this. Unless that can be planned around in advance.