Repository navigation
Tasproj version identifier can have a different decimal mark #2377
Description
A user reported on Discord that the movie version was being saved with a comma instead of a period with certain language settings:
MovieVersion BizHawk v2.0 Tasproj v1,1
instead of
MovieVersion BizHawk v2.0 Tasproj v1.1
This is a problem: the decimal separator written the movie file should not be operating-system dependent.
Activity
[-]Tasproj version identifier can have a different mark[/-][+]Tasproj version identifier can have a different decimal mark[/+]zeromus commentedon Sep 5, 2020
Can we use
DefaultThreadCurrentCultureand set it to Invariant so this scourge is eradicated?YoshiRulz commentedon Sep 5, 2020
I assume that overrides the system language/culture for the lifetime of the program? That would prevent us adding translations in the future.
zeromus commentedon Sep 5, 2020
Translations arent in the plan for bizhawk EVER. I do not accept this rationale.
Fix de/serialisation of .tasproj MovieVersion header (fixes #2377)