Trigger a build upon pull requests - #34
Open
bvanassche wants to merge 4 commits into
Open
Conversation
major() and minor() are available on Linux but not on all operating systems. Hence, only use major() and minor() if these macros are available. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Fix the following build error that is reported when using a C23 compiler:
../include/f2fs_fs.h:33:25: error: two or more data types in declaration specifiers
33 | typedef u8 bool;
| ^~~~
../include/f2fs_fs.h:33:1: warning: useless type name in empty declaration
33 | typedef u8 bool;
| ^~~~~~~
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Replace strncpy with memcpy when copying column headers. We copy exactly strlen(name[i]) bytes without intending to copy the null terminator (since the buffer is already padded with spaces). Using strncpy with source length as limit triggers stringop-truncation warnings in modern compilers, which is avoided by using memcpy. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Add a workflow that builds the source code with gcc and also with clang. Signed-off-by: Bart Van Assche <bvanassche@acm.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the f2fs-tools code upon push and pull requests. This is considered a best practice. Additionally, fix a build error, a compiler error and a portability issue I ran into.