Skip to content

Clarify capability inheritance and defaults #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Richard-LZ-Zhang merged 1 commit into from
Oct 27, 2026
Merged

Clarify capability inheritance and defaults #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions synpath/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,10 +477,14 @@ def _clean(params: Any) -> Any:


def complete_capabilities(cls: type) -> None:
"""Fill `cls.has` from `CAPABILITIES`, refusing typos and illegal values.
"""Build a complete `cls.has` map for every name in `CAPABILITIES`.

Shared by the read adapters and the trading adapters, so both answer
every question the same way. See `Exchange.__init_subclass__`.
Validate the class's own declarations, rejecting unknown capability names
and illegal values. Inherit from the nearest ancestor in method resolution
order with a non-empty `has` dictionary, then apply the class's overrides.
Capabilities declared by neither default to `False`.

Shared by read, trading and WebSocket adapters during subclass creation.
"""
declared = cls.__dict__.get("has", {})
if not isinstance(declared, dict):
Expand Down
Loading