Skip to content

Sanitize message and file path inputs#779

Open
Kcchouette wants to merge 1 commit into
Syncplay:masterfrom
Kcchouette:patch-2
Open

Sanitize message and file path inputs#779
Kcchouette wants to merge 1 commit into
Syncplay:masterfrom
Kcchouette:patch-2

Conversation

@Kcchouette
Copy link
Copy Markdown

Remove carriage return and newline characters from messages and file paths.

Remove carriage return and newline characters from messages and file paths.
@daniel-123
Copy link
Copy Markdown
Contributor

Does this change solve a specific problem you encountered?

In messages I could see newlines as potentially useful.

In filenames, technically both \r and \n are valid characters. Normalizing filenames is an awfully complex issue that's OS and filesystem dependent and I would prefer not to open that specific can of worms without a very good reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants