fix: safe resp - #1745
Merged
Merged
Conversation
Nexisato
commented
Aug 21, 2026
Nexisato
commented
Collaborator
- avoid of null data type
SAKURA-CAT
requested changes
Aug 21, 2026
…rors Per review feedback on #1745: rename the private _created_at_ts() helper to a public created_at_ts property next to created_at, and wrap parse_timestamp_s failures with the experiment path so missing/invalid createdAt reports context instead of a bare timestamp error.
…-save format_output now dumps the payload to indented JSON bytes a single time, echoes the bytes directly, and returns them so api_command can hand the same buffer to save_output; the payload dict is dropped after serialization, so --save no longer adds a second full orjson pass or extra copies.
SAKURA-CAT
added
the
backport release/v0.8
SAKURA-CAT
approved these changes
Aug 21, 2026
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/v0.8
git worktree add -d .worktree/backport/release/v0.8/pr-1745 origin/release/v0.8
cd .worktree/backport/release/v0.8/pr-1745
git switch --create backport/release/v0.8/pr-1745
git cherry-pick -x af3b54c6c00e5ae4e916cc21a53f5f84fce4e8f7 |
Member
没事，这次测试一下，v0.8其实也不再维护 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.