Repository navigation
Implement incremental delta sync engine (Milestone M3, v6.0.12) - #13
Merged
Merged
Conversation
…dentialProviderService leak - Added 26 functional E2E tests covering online data refresh, offline vault replica, authentication lifecycle, sync resilience, and resource management - Fixed CredentialProviderService$1 framework Binder stub memory leak reported by LeakCanary via reflection cleanup on onDestroy - Added LeakCanary/Shark ignoredInstanceField reference matchers for AOSP Android 14+ CredentialProviderService Binder stubs - Bumped app version to 6.0.10 (versionCode 67)
- Implement DeltaSyncStrategy, ChangesApplier, BootstrapStrategy, and ManifestReconciler - Orchestrate synchronization via SyncEngine with transparent 410 Gone fallback - Add Room database Schema 31 with persistent SyncState table and migration - Wire WorkManager background scheduling via SyncWorker and SyncScheduler - Integrate FullDataRefreshExecutor with SyncEngine to enforce fast delta sync when local replica exists - Ensure full sync/bootstrap only occurs when local replica data is absent - Add comprehensive unit and integration E2E test suites - Bump version to 6.0.12 (versionCode 69)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR delivers Milestone M3 of the Passly synchronization protocol (
sync/1) forpassly_android, alongside release hygiene bumping to v6.0.12 (versionCode69).Key Deliverables:
Incremental Delta Synchronization Engine (
core/sync):DeltaSyncStrategy: Consumes paginated change journal from/sync/changes.json?since={localSeq}and parses additions, modifications, and deletions.ChangesApplier: Atomically persists batch operations acrossresources,secrets, andpermissionstables in a single Room transaction while advancinglocalSeq.BootstrapStrategy: Transparent recovery handler when receiving HTTP410 Gone(cursor older than server retention threshold) or for initial onboarding via/sync/bootstrap.json.ManifestReconciler: Periodic sanity verification against/sync/manifest.jsonto identify and prune orphaned or revoked entries.SyncEngine: Master coordinator orchestrating delta sync, 410 Gone fallback, manifest reconciliation, backoff, and telemetry.Room Database Schema 31 (
core/database):SyncStateentity andSyncStateDaoto durably persist monotoniccursor, serverepoch,lastSyncTimestamp, andlastReconcileTimestamp.Migration30to31.ktwith verified schema snapshot.Background WorkManager Scheduling (
core/sync/work):SyncWorker: Coroutine worker withNetworkType.CONNECTEDconstraint and exponential backoff.SyncScheduler: Enqueues periodic background runs (15 min intervals) and dispatches immediate manual sync triggers.UI Refresh Integration & Data Absence Policy (
core/fulldatarefresh):FullDataRefreshExecutorintoSyncEngine.HomeScreenandOtpScreen.Testing & Verification:
:sync.:fulldatarefresh.